[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+        for (InitListExpr::iterator II = E->begin(), IE = E->end();
+             II != IE; ++II)
+          Visit(*II);
----------------
nickdesaulniers wrote:
> void wrote:
> > nickdesaulniers wrote:
> > > nickdesaulniers wrote:
> > > > `std::for_each`?
> > > Sorry, posted that comment as you uploaded the next version.  This should be highlighting L15618 to L15620.
> > That's no used anywhere else in the source code. Maybe there's another mechanism that they use?
> Oh, looks like it was only added to C++17; I think Clang+LLVM use a lower language version.  Did C++ stl really not have a way to apply the same function over an iterator until C++17?
At least a range for would make this more concise:

```
for (auto& II : *E)
  Visit(II);
```


https://reviews.llvm.org/D52854