[PATCH] D52808: [cland] Dex: fix/simplify trigram generation

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

> The problem is LSP clients are free to assume that the result list is complete (unless marked as incomplete) and therefore will never retrieve the better symbols.

Good point. Thanks for the explanation!



================
Comment at: clangd/index/dex/Dex.cpp:222
   SPAN_ATTACH(Tracer, "query", llvm::to_string(*Root));
-  vlog("Dex query tree: {0}", *Root);
+  log("Dex query tree: {0}", *Root);
 
----------------
should this still be a `vlog`?


================
Comment at: clangd/index/dex/Trigram.h:47
+/// For "FooBar" we get the following trigrams:
+///  {f, b, fo, fb, foo, fob, fba, oob, oba, bar}.
+///
----------------
is `b` still generated?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52808