[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added inline comments.


================
Comment at: clang-tidy/utils/Matchers.cpp:20
+matchesAnyListedName(const std::vector<std::string> &NameList) {
+  SmallString<256> NameRegEx;
+  llvm::raw_svector_ostream NameOut(NameRegEx);
----------------
lebedev.ri wrote:
> ```
> if(NameList.empty())
>   return false;
> ```
`false`? But this functions returns `Matcher<NamedDecl>`.


================
Comment at: clang-tidy/utils/Matchers.cpp:29
+    NameOut << "^(?!.*)";
+  return matchesName(NameRegEx.str());
+}
----------------
lebedev.ri wrote:
> Why do you need to 'concatenate' all the regexes?
> Why not simply match in a loop?
This is what @JonasToth suggested. How to match them in a loop if the function returns a `Matcher<NamedDecl>`?


https://reviews.llvm.org/D52727