[PATCH] D52871: [clangd] Use canonical declarations in ReferenceFinder.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Nice catch!



================
Comment at: unittests/clangd/XRefsTests.cpp:1185
     std::vector<Matcher<Location>> ExpectedLocations;
     for (const auto &R : T.ranges("foo"))
       ExpectedLocations.push_back(RangeIs(R));
----------------
hmm, it looks like the "foo" labels on the ranges don't need to be there, and they hurt readability.

Want to remove them from all the tests, rather than add them to the method call test where they're missing?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52871