[PATCH] D52726: [clangd] Support refs() in dex. Largely cloned from MemIndex.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 4 01:31:24 PDT 2018
hokein added inline comments.
================
Comment at: clangd/index/dex/Dex.h:61
}
// Symbols are owned by BackingData, Index takes ownership.
+ template <typename SymbolRange, typename RefsRange, typename Payload>
----------------
nit: this comment is stale too.
================
Comment at: unittests/clangd/DexTests.cpp:618
+ Files.push_back(R.Location.FileURI);
+ });
+}
----------------
The test seems doesn't verify any thing?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
More information about the cfe-commits
mailing list