[PATCH] D52117: Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

[Pekka Jääskeläinen via Phabricator via cfe-commits]

pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.

I glimpsed over this without spotting anything crucial. My Clang code base knowledge is a bit lightweight though so you might want to wait for an another reviewer. On the other hand, the semantics seem to be retained so it might be safe to commit this in case the tests still pass.

We need to remember to update pocl to produce this format then.



================
Comment at: lib/CodeGen/CGLoopInfo.cpp:337
+  // llvm.loop.parallel_accesses to include these accesses. At the moment a loop
+  // has an access group iff it is parallel such that the last propert already
+  // is a "llvm.loop.parallel_accesses".
----------------
typo 'propert'


================
Comment at: test/CodeGenCXX/pragma-loop-safety-nested.cpp:6
 void vectorize_nested_test(int *List, int Length) {
 #pragma clang loop vectorize(assume_safety) interleave(disable) unroll(disable)
   for (int i = 0; i < Length; ++i) {
----------------
Can you add a test case of a nested loop that is not "perfect", that is, has accesses also in the outer loop bodies?


Repository:
  rC Clang

https://reviews.llvm.org/D52117