[PATCH] D52843: Update Clang Windows getting started docs

[Reid Kleckner via Phabricator via cfe-commits]

rnk marked 3 inline comments as done.
rnk added inline comments.


================
Comment at: clang/www/get_started.html:179
   <ul>
     <li><tt>svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm</tt></li>
   </ul>
----------------
STL_MSFT wrote:
> Can these be HTTPS? (I had to figure out HTTPS incantations for `git clone` and `git svn init`, but I haven't used SVN directly.)
These can, but getgnuwin32 is http-only for now I guess. =/


================
Comment at: clang/www/get_started.html:197
+    <li>If you are using Visual Studio 2017:
+      <tt>cmake -G "Visual Studio 15 2017 Win64" ..\llvm</tt></li>
+    <li>This will generate x64 binaries by default, which should perform better.
----------------
steveire wrote:
> smeenai wrote:
> > Does the Win64 generator automatically imply `-Thost=x64`?
> Nope.
> 
> And using `"Visual Studio 15 2017 Win64"` is deprecated. Use `-G "Visual Studio 15 2017" -A x64` instead as per https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2015%202017.html
Thanks, check the new instructions, hopefully they are correct.


================
Comment at: clang/www/get_started.html:246
+        <tt>"C:\Program Files (x86)\Microsoft Visual
+          Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64</tt>
+      </li>
----------------
zturner wrote:
> zturner wrote:
> > STL_MSFT wrote:
> > > This assumes the Professional SKU; perhaps the instructions should be for Community?
> > Would something like `%VS2017INSTALLDIR%` be even better?
> Granted it assumes 2017, but not as bad as assuming both Professional SKU + default installation path.
I'll change it, and hopefully users of Professional will understand what "run the appropriate vcvarsall.bat incantation" means.


https://reviews.llvm.org/D52843