[PATCH] D52843: Update Clang Windows getting started docs
Stephan T. Lavavej via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 3 15:29:06 PDT 2018
STL_MSFT added inline comments.
================
Comment at: clang/www/get_started.html:160
<a href="http://www.cmake.org/cmake/resources/software.html">
http://www.cmake.org/cmake/resources/software.html</a></li>
+ <li><b>Visual Studio 2015 or later</b></li>
----------------
This URL redirects to `https://cmake.org/download/`. (Clang's docs should use HTTPS everywhere possible, especially for self-links.)
================
Comment at: clang/www/get_started.html:164
<a href="http://www.python.org/download/">
http://www.python.org/download/</a></li>
<li><b>GnuWin32 tools</b>
----------------
Redirected to `https://www.python.org/downloads/`.
================
Comment at: clang/www/get_started.html:179
<ul>
<li><tt>svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm</tt></li>
</ul>
----------------
Can these be HTTPS? (I had to figure out HTTPS incantations for `git clone` and `git svn init`, but I haven't used SVN directly.)
================
Comment at: clang/www/get_started.html:246
+ <tt>"C:\Program Files (x86)\Microsoft Visual
+ Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64</tt>
+ </li>
----------------
This assumes the Professional SKU; perhaps the instructions should be for Community?
https://reviews.llvm.org/D52843
More information about the cfe-commits
mailing list