[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 3 12:53:51 PDT 2018


aaron.ballman added inline comments.


================
Comment at: clang-tidy/performance/ForRangeCopyCheck.h:43
   const bool WarnOnAllAutoCopies;
+  const std::vector<std::string> WhiteListTypes;
 };
----------------
Nit: can you name it `AllowedTypes` rather than `WhiteListTypes`? Use similar nomenclature ("allow" instead of "white") elsewhere as well.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52727





More information about the cfe-commits mailing list