[PATCH] D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 3 12:43:43 PDT 2018
aaron.ballman added inline comments.
================
Comment at: clang-tidy/utils/ExprSequence.cpp:103
for (const Stmt *Parent : getParentStmts(S, Context)) {
+ // For statements that have multiple parents, make sure we're using the
+ // parent that lies within the sub-tree under Root.
----------------
JonasToth wrote:
> I find the first part of the comment unclear. Does this loop handle `for` only?
I think this means English "for" and not C `for`. Could rewrite to `If a statement has multiple parents, ` instead.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52782
More information about the cfe-commits
mailing list