[PATCH] D52752: [clang-query] Add comment token handling
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 3 01:29:47 PDT 2018
steveire marked an inline comment as done.
steveire added inline comments.
================
Comment at: clang-query/QueryParser.cpp:42
+ End = Begin;
+ return StringRef(Begin, 0);
+ }
----------------
aaron.ballman wrote:
> This is just returning an empty `StringRef`, isn't it? Might as well return `StringRef()` through the default constructor for clarity.
I copied the pattern from a few lines above, but there is it actually necessary as it is used in the code completion infrastructure. Comments don't participate in code completion so I changed it as described.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52752
More information about the cfe-commits
mailing list