[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 2 14:46:33 PDT 2018
aaron.ballman added a comment.
In https://reviews.llvm.org/D52398#1251894, @aaronpuchert wrote:
> @delesley Any objections to this?
>
> It's certainly useful for our code base, because our `assert`-like macros use `__builtin_expect`, but I'm not sure if that applies to the general public.
I think you're fine to commit -- this seems like an intuitive extension to the functionality; if there are issues, we can revert post-commit.
Repository:
rC Clang
https://reviews.llvm.org/D52398
More information about the cfe-commits
mailing list