[PATCH] D52752: [clang-query] Add comment token handling

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 2 14:39:10 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a minor nit.



================
Comment at: clang-query/QueryParser.cpp:42
+    End = Begin;
+    return StringRef(Begin, 0);
+  }
----------------
This is just returning an empty `StringRef`, isn't it? Might as well return `StringRef()` through the default constructor for clarity.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52752





More information about the cfe-commits mailing list