[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Fair enough!



================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:306-307
+                       const FIDMap& FM,
+                       const Preprocessor &PP,
+                       AnalyzerOptions &AnOpts) {
+  ReportPiece(o, P, FM, PP, AnOpts, /*indent*/ 4, /*depth*/ 0,
----------------
Maybe just make this function non-`static` instead of passing members around manually?


================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:315-316
                         const FIDMap& FM,
                         const Preprocessor &PP,
+                        AnalyzerOptions &AnOpts,
                         unsigned indent,
----------------
And this.


Repository:
  rC Clang

https://reviews.llvm.org/D52787