[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.

I support continuing our practice of being silent by default, and not implementing anything like the noisy default version banner printing that MSVC does, or this filename printing. I think setting this flag is something for cmake or the VS integration to do. Only someone who knows something about the progress printing model can set it correctly.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:3533-3534
   CmdArgs.push_back(getBaseInputName(Args, Input));
+  if (Arg *A = Args.getLastArg(options::OPT_echo_main_file_name))
+    A->render(Args, CmdArgs);
 
----------------
Is a -cc1 flag actually necessary? I was imagining we'd print it in the driver before we launch the compile job.


https://reviews.llvm.org/D52773