[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

[Peter Smith via Phabricator via cfe-commits]

peter.smith added a comment.

In https://reviews.llvm.org/D52784#1252569, @rengolin wrote:

> Hi Peter,
>
> Looks ok. Why did you need to change all cmdlines to have -EL? I imagine you just need one for each case, everything else remains the default (which should still work).


I thought that in general we wouldn't know what the default endianness of the assembler we are targeting is so it was safest to be explicit. For a cross-toolchain it is probably inherent in the name, but in theory we could be running clang on a native big-endian system where the assembler is just called as.

> Also, it would be interesting to know what happens on cases like "aarch64_be -EL" et al, and have negative tests for them.

Ok will add some more tests.

> cheers,
> --renato




https://reviews.llvm.org/D52784