[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 2 06:57:47 PDT 2018
aaron.ballman added inline comments.
================
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190
+ for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
+ EXPECT_EQ("", Sema.Errors[i]);
+ }
----------------
Why are empty errors created? I would have expected this to be `EXPECT_EQ(0, Sema.Errors.size())`.
(If this formulation is desired, it should use a range-based for loop.)
Repository:
rC Clang
https://reviews.llvm.org/D52751
More information about the cfe-commits
mailing list