[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

[Donát Nagy via Phabricator via cfe-commits]

donat.nagy added a comment.

Does this checker handle the expansion of variadic macros introduced in C++11 (see syntax (3) and (4) here <https://en.cppreference.com/w/cpp/preprocessor/replace>) and the `#` and `##` preprocessor operators?



================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:755
+        if (It->is(tok::l_paren)) {
+          while ((++It)->isNot(tok::r_paren)) {
+            assert(It->isNot(tok::eof) &&
----------------
I fear that this does not handle nested parentheses correctly; e.g. in a case like `MACRO_ONE(foo, MACRO_TWO(bar, baz), spam)`, it does not skip `, spam)`.


https://reviews.llvm.org/D52742