[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

[Hans Wennborg via Phabricator via cfe-commits]

hans added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:792
   Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name);
+  if (Args.hasArg(OPT_echo_main_file_name))
+    llvm::outs() << Opts.MainFileName << "\n";
----------------
zturner wrote:
> steveire wrote:
> > I'll have to keep a patch around anyway for myself locally to remove this condition. But maybe someone else will benefit from this.
> > 
> > What do you think about changing CMake to so that this is passed by default when using Clang-CL?
> > 
> Do you mean llvms cmake?  Or cmake itself?  Which generator are you using?
Can't you just configure your build to pass the flag to clang-cl?

I suppose CMake could be made to do that by default when using clang-cl versions that support the flag and using the MSBuild generator, but that's for the CMake community to decide I think. Or perhaps our VS integration could do that, but it gets tricky because it needs to know whether the flag is supported or not.


https://reviews.llvm.org/D52773