[PATCH] D52538: [MinGW] Allow using ASan

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: lib/Driver/ToolChain.cpp:370-373
+  const char *Suffix = Shared ? (Triple.isWindowsGNUEnvironment()
+                                     ? ".dll.a"
+                                     : Triple.isOSWindows() ? ".lib" : ".so")
                               : (IsITANMSVCWindows ? ".lib" : ".a");
----------------
rnk wrote:
> I think these conditionals have outgrown conditional expressions. Maybe just patch it upafterwards with a special case:
> ```
> if (Shared && Triple.isWindowsGNUEnvironment())
>   Suffix = ".dll.a";
> ```
Ok


================
Comment at: lib/Driver/ToolChains/MinGW.cpp:234
+      if (Sanitize.needsAsanRt()) {
+        // MinGW always links against a shared CRT.
+        CmdArgs.push_back(
----------------
rnk wrote:
> As in, shared msvcrt? Not shared mingw rt, right?
Right, yes - a shared msvcrt, but the mingw crt additions/wrappings/glue are statically linked into each module.


Repository:
  rC Clang

https://reviews.llvm.org/D52538