[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 12:58:57 PDT 2018


efriedma added a comment.

Again, I'm not sure we really want this... we don't really like adding new off-by-default warnings, and we don't usually add diagnostics to enforce style.



================
Comment at: include/clang/Basic/DiagnosticGroups.td:163
 def CXX11ExtraSemi : DiagGroup<"c++11-extra-semi">;
+def ExtraSemiPedantic : DiagGroup<"extra-semi-pedantic">;
 def ExtraSemi : DiagGroup<"extra-semi", [CXX98CompatExtraSemi,
----------------
We usually only use "pedantic" in the names of warnings which are enabled by the "-pedantic" flag.


Repository:
  rC Clang

https://reviews.llvm.org/D52695





More information about the cfe-commits mailing list