[PATCH] D52738: [AST] Pack the bit-fields of FunctionProtoType into Type.

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

The `reinterpret_cast` is legal because it's dynamic storage that's never actually accessed as an `ExceptionType`.  IIRC there are reasonable-sounding strict-aliasing arguments about the validity of doing pointer arithmetic using pointers of the wrong type for the objects stored there, but they've always come with a "and if we actually enforced the rules that way, we'd completely break the world" disclaimer.

I agree with all the changes you've made here; thank you for seeing this through.


Repository:
  rC Clang

https://reviews.llvm.org/D52738