[PATCH] D52735: [analyzer][NFC] Refactor functions in PlistDiagnostics to take Preproc as parameter

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 10:55:15 PDT 2018


george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:98
+
+  const SourceManager &SM = PP.getSourceManager();
+  const LangOptions &LangOpts = PP.getLangOpts();
----------------
+1 for identifying redundant arguments.


https://reviews.llvm.org/D52735





More information about the cfe-commits mailing list