[PATCH] D51429: [AArch64] Return Address Signing B Key Support

Luke Cheeseman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 08:43:34 PDT 2018


LukeCheeseman added inline comments.


================
Comment at: include/clang/Frontend/CodeGenOptions.h:117
 
+  enum SignReturnAddressKeyValue { AKey, BKey };
+
----------------
javed.absar wrote:
> Perhaps a line of comment on each enum-value would be useful (much like the code around).
I'm not sure what value there would be in adding extra comments here, I think the values are fairly self explanatory.


https://reviews.llvm.org/D51429





More information about the cfe-commits mailing list