[PATCH] D52721: [Preprocessor] Fix a crash when handling non-alpha include header.

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 07:10:45 PDT 2018


kristina added inline comments.


================
Comment at: lib/Lex/PPDirectives.cpp:1898
+          }
+          if (Filename.empty())
+            return Filename;
----------------
sammccall wrote:
> simplify the logic by merging with the while loop? (and drop the assert)
I thought the assert was a good idea in case a similar issue popped up again (somehow triggering this but in reverse, not sure if that makes sense), it's a no-op in upstream release builds anyway.


Repository:
  rC Clang

https://reviews.llvm.org/D52721





More information about the cfe-commits mailing list