[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 04:59:53 PDT 2018


alexfh added inline comments.


================
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+  // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+  // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+  // CHECK-NOTES: 113:29: note: FIX-IT applied suggested code changes
----------------
This is an example of not very useful CHECK-NOTES patterns.  The corresponding notes are issued in Clang and there's not much value in testing them here. They also duplicate the CHECK-FIXES pattern below. Should the script filter these notes out, maybe?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52691





More information about the cfe-commits mailing list