[PATCH] D52711: [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 02:47:55 PDT 2018


sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.

- Corpus avoids having to pass size to the true iterator, and (soon) any iterator that might optimize down to true.
- Shorten names of factory functions now they're scoped to the Corpus. intersect() and unionOf() rather than createAnd() or createOr() as this seems to read better to me, and fits with other short names. Opinion wanted!
- DEFAULT_BOOST_SCORE --> 1. This is a multiplier, don't obfuscate identity.
- Simplify variadic templates in Iterator.h


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52711

Files:
  clangd/index/dex/Dex.cpp
  clangd/index/dex/Dex.h
  clangd/index/dex/Iterator.cpp
  clangd/index/dex/Iterator.h
  clangd/index/dex/PostingList.cpp
  unittests/clangd/DexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52711.167687.patch
Type: text/x-patch
Size: 19507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181001/78b65319/attachment-0001.bin>


More information about the cfe-commits mailing list