[PATCH] D52401: Remove redundant null pointer check in operator delete

Zhihao Yuan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 30 19:17:24 PDT 2018


lichray added a comment.

In https://reviews.llvm.org/D52401#1250551, @MaskRay wrote:

> `__free_hook` (defaults to NULL) is a user-supplied hook (https://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html).


Very interesting, that means if we don't apply this patch, we essentially breaks glic `__free_hook`, because that one expects to be able to observe null pointers.


Repository:
  rL LLVM

https://reviews.llvm.org/D52401





More information about the cfe-commits mailing list