[PATCH] D52320: AMDGPU: add __builtin_amdgcn_update_dpp

Brian Sumner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 28 15:47:32 PDT 2018


b-sumner added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315
+  case AMDGPU::BI__builtin_amdgcn_update_dpp: {
+    llvm::SmallVector<llvm::Value *, 6> Args;
+    for (unsigned I = 0; I != 6; ++I)
----------------
arsenm wrote:
> The only difference between this and mov_dpp is the argument count and the intrinsic ID, so you can combine the cases
We should really drop mov_dpp.  It will be easier to do so if we keep the cases separate. 


https://reviews.llvm.org/D52320





More information about the cfe-commits mailing list