[PATCH] D52581: [AST] Revert mangling changes from r339428

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 28 01:45:48 PDT 2018


theraven added a comment.

In https://reviews.llvm.org/D52581#1248306, @smeenai wrote:

> The simplest option is something like https://reviews.llvm.org/P8109, where we add a `.objc` discriminator when mangling the RTTI itself. It would require the GNUStep runtime for Windows to be altered accordingly (e.g. https://github.com/gnustep/libobjc2/blob/master/eh_win32_msvc.cc#L85 would have to use `".objc.PAU"` instead of `".PAU.objc_cls_"`); would that be acceptable, @theraven and @DHowett-MSFT?


I think that's fine.  We have shipped the new ABI for ELF platforms, but not yet for Windows (and we have a few other patches still needed in Clang), and haven't finished the WinObjC integration, so we don't yet have a stable ABI that anyone cares about preserving for this - we explicitly disabled the Windows code paths in clang 7.0, so no one can use them with an unstable ABI without patching clang.  As long as we come up with some consistent mangling and it's sensibly documented, I'm happy to make the runtime changes for it.


Repository:
  rC Clang

https://reviews.llvm.org/D52581





More information about the cfe-commits mailing list