[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 27 07:22:07 PDT 2018


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/index/Merge.cpp:42
      //  3) now yield all the dynamic symbols we haven't processed.
+     trace::Span Tracer("MergedIndex fuzzyFind");
      bool More = false; // We'll be incomplete if either source was.
----------------
might be fun to add static/dynamic/both counts


================
Comment at: clangd/index/dex/Dex.cpp:143
          "There must be no :: in query.");
+  trace::Span Tracer("Dex fuzzyFind");
   FuzzyMatcher Filter(Req.Query);
----------------
We should attach the query tree to the span here.

Right now that's not practical as the dump() representation holds the posting lists rather than their token, but maybe add a FIXME?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52611





More information about the cfe-commits mailing list