r343205 - Revert untintentionally commited changes
Kristof Umann via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 27 05:46:38 PDT 2018
Author: szelethus
Date: Thu Sep 27 05:46:37 2018
New Revision: 343205
URL: http://llvm.org/viewvc/llvm-project?rev=343205&view=rev
Log:
Revert untintentionally commited changes
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h?rev=343205&r1=343204&r2=343205&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h Thu Sep 27 05:46:37 2018
@@ -79,9 +79,9 @@ class FieldNode {
protected:
const FieldRegion *FR;
- // TODO: This destructor shouldn't be virtual, but breaks buildbots with
- // -Werror -Wnon-virtual-dtor.
- virtual ~FieldNode() = default;
+ /// FieldNodes are never meant to be created on the heap, see
+ /// FindUninitializedFields::addFieldToUninits().
+ /* non-virtual */ ~FieldNode() = default;
public:
FieldNode(const FieldRegion *FR) : FR(FR) {}
More information about the cfe-commits
mailing list