[PATCH] D52544: Improve diagnostics range reporting.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 27 05:04:06 PDT 2018
kadircet added inline comments.
================
Comment at: unittests/clangd/ClangdUnitTests.cpp:82
o]]();
- foo()$semicolon[[]]
+ foo()$semicolon[[]]//with comments
$unk[[unknown]]();
----------------
ioeric wrote:
> What is this `//with comments` for? Maybe explain it in the comment if it does something?
In the previous implementation we were highlighting the "//with comments" as it was the token at that location. But since this is an insertion and we are not going to replace that token it seemed confusing to highlight all the comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52544
More information about the cfe-commits
mailing list