[PATCH] D52544: Improve diagnostics range reporting.

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/Diagnostics.cpp:55
   // Accept the first range that contains the location.
+  llvm::Optional<Range> PossibleRange;
   for (const auto &CR : D.getRanges()) {
----------------
nit: Maybe `FallbackRange`?


================
Comment at: unittests/clangd/ClangdUnitTests.cpp:82
 o]]();
-      foo()$semicolon[[]]
+      foo()$semicolon[[]]//with comments
       $unk[[unknown]]();
----------------
What is this `//with comments` for? Maybe explain it in the comment if it does something?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52544