[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

Simon Atanasyan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 26 13:46:06 PDT 2018


atanasyan added inline comments.


================
Comment at: lib/Driver/Driver.cpp:492
+                 .Case("64", Target.get64BitArchVariant())
+                 .Default(Target);
+
----------------
rnk wrote:
> We should emit a diagnostic for invalid -mabi=values.
We already do that:

  $ clang -target mips-linux-gnu -c test.c -mabi=xxx
  error: unknown target ABI 'xxx'


Repository:
  rC Clang

https://reviews.llvm.org/D52290





More information about the cfe-commits mailing list