[PATCH] D51686: [OpenMP] Improve search for libomptarget-nvptx
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 26 12:45:49 PDT 2018
ABataev added inline comments.
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:515
+ if (Arg *A = Args.getLastArg(options::OPT_libomptarget_nvptx_path_EQ))
+ CmdArgs.push_back(Args.MakeArgString(Twine("-L") + A->getValue()));
+
----------------
`const Arg *A`
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:651
+
+ if (Arg *A = DriverArgs.getLastArg(options::OPT_libomptarget_nvptx_path_EQ))
+ LibraryPaths.push_back(A->getValue());
----------------
`const Arg *`
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
+ // Add path to lib / lib64 folder.
+ SmallString<256> DefaultLibPath =
----------------
You're changing the order of the lookup for the paths. Is this intended? If so, you need the test for this.
Repository:
rC Clang
https://reviews.llvm.org/D51686
More information about the cfe-commits
mailing list