[PATCH] D52434: [OpenMP] Make default schedules for NVPTX target regions in SPMD mode achieve coalescing

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 26 12:29:39 PDT 2018


ABataev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9199
+      OpenMPDistScheduleClauseKind *ScheduleKind, llvm::Value *&Chunk) const {
+  return;
+}
----------------
Remove `return;`, it is not required


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:345
+  void setDefaultDistScheduleAndChunk(CodeGenFunction &CGF,
+      OpenMPDistScheduleClauseKind *ScheduleKind,
+      llvm::Value *&Chunk) const override;
----------------
Modify it to be the reference rather than the pointer.


Repository:
  rC Clang

https://reviews.llvm.org/D52434





More information about the cfe-commits mailing list