[PATCH] D52545: [docs] Update PostingList string representation format

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 26 07:54:42 PDT 2018


ioeric added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:97
   /// ChildN is N-th iterator child. Raw iterators over PostingList are
-  /// represented as "[ID1, ID2, ..., {IDN}, ... END]" where IDN is N-th
-  /// PostingList entry and the element which is pointed to by the PostingList
-  /// iterator is enclosed in {} braces.
+  /// represented as "[(...)? (IDN | END) (...)?]" where IDN is N-th
+  /// PostingList entry.
----------------
nit: `[(...)? (IDN | END) (...)?]` is accurate but can be really confusing... I think it's okay to be a bit inaccurate with just `[ ... CurID ... ]`.


https://reviews.llvm.org/D52545





More information about the cfe-commits mailing list