[PATCH] D52360: [clang-tidy] Fix for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D52360#1246452, @lebedev.ri wrote:

> I disagree, it **must** not have false-negatives by default.


What kind of false-negatives could be caused by smart pointers or references? Sane people do not name a type pointer or reference if they are not. Such types must never be passed by reference. Few people will use the check if they have to set tons of options for the basic expected behavior. For example in `CodeChecker` this check is disabled by default and is only enabled in the `Sensitive` profile.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52360