[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

Simon Atanasyan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 26 02:09:23 PDT 2018


atanasyan added a comment.

In https://reviews.llvm.org/D52290#1245222, @rnk wrote:

> Should `--target=mipsZZZ -mabi=n64` be meaningful? What does `clang --target=i686-linux-gnu -m64` do? If this matches that, then let's do it.


Thanks. Initially I thought that providing different target triple and `-mabi` option explicitly is an error. But now I see that it's better and consistent with other targets to adjust a target triple accordingly to `-mabi` options in any (implicit/explicit) case. I will update the patch soon.


Repository:
  rC Clang

https://reviews.llvm.org/D52290





More information about the cfe-commits mailing list