[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 25 22:43:19 PDT 2018


ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: clangd/CodeComplete.cpp:507
+      if (Snippet->front() == '<')
+        return EmptyArgs ? "<$0>()" : "<$1>($0)";
+      if (Snippet->front() == '(')
----------------
kadircet wrote:
> maybe have something like `<$1>()$0` when arguments are empty so that user can jump to end.
Thanks, this looks consistent with other cases


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52422





More information about the cfe-commits mailing list