[PATCH] D52440: Emit lifetime markers for temporary function parameter aggregates

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGExpr.cpp:176
+      pushFullExprCleanup<CallLifetimeEnd>(NormalEHLifetimeMarker,
+                                           Slot.getAddress(), Size);
+    }
----------------
This is problematic because we're not necessarily in a scope that usefully limits the duration of cleanups — we don't push full-expression scopes when emitting an arbitrary statement.  Probably we should, but we don't.

If you'd like to take a look at solving that problem first, that would be great.


Repository:
  rC Clang

https://reviews.llvm.org/D52440