[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 25 15:03:16 PDT 2018


kristina updated this revision to Diff 166996.
kristina added a comment.

Split up the tests for ELF into tests 1). Checking whether CF can be built and linked correctly 2). Asm section tests originally from `CFStrings.c` as they had additional ELF-related cruft that should have been a separate test. Renamed `CFStrings.c` to `cfstring3.c` for consistency, which now tests ELF/COFF/MachO in a consistent fashion versus having a hunk of out of place ELF-specific tests.


Repository:
  rC Clang

https://reviews.llvm.org/D52344

Files:
  lib/CodeGen/CodeGenModule.cpp
  test/CodeGen/CFStrings.c
  test/CodeGen/cfstring-elf-cfbuild-x86_64.c
  test/CodeGen/cfstring-elf-sections-x86_64.c
  test/CodeGen/cfstring3.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52344.166996.patch
Type: text/x-patch
Size: 18930 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180925/91df1306/attachment-0001.bin>


More information about the cfe-commits mailing list