[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 25 06:36:04 PDT 2018


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!

Maybe file a bug on figuring out the /Gs story and add a FIXME linking to it. Weird.



================
Comment at: include/clang/Driver/CLCompatOptions.td:118
+def _SLASH_O : CLJoined<"O">,
+  HelpText<"Set many /O flags at once; e.g. '/O2y-' is the same as '/O2 /y-'">,
+  MetaVarName<"<flags>">;
----------------
very nit: Maybe s/many/several/ or s/many/multiple/


https://reviews.llvm.org/D52266





More information about the cfe-commits mailing list