[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.
Kristina Brooks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 24 07:21:44 PDT 2018
kristina added a comment.
Alright, I guess I'll land it if there's no objections to it, `cfstring` is staying as is, the PE/COFF codepath is not affected in terms of functionality and test is fine I think, hopefully `x86_64-elf` will not yield different results on different machines in terms of alignment etc. That should allow building CF on x86_64 Linux without any additional runtime and fix a crash, as well as make the check explicit instead of relying on a blind `cast<>`.
Repository:
rC Clang
https://reviews.llvm.org/D52344
More information about the cfe-commits
mailing list