[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 24 07:21:45 PDT 2018


ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
ioeric updated this revision to Diff 166667.
ioeric added a comment.

- update comment


The file stats can be reused when preamble is reused (e.g. code
completion). It's safe to assume that cached status is not outdated as we
assume preamble files to remain unchanged.

On real file system, this made code completion ~20% faster on a measured file
(with big preamble). The preamble build time doesn't change much.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52419

Files:
  clangd/ClangdServer.cpp
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h
  clangd/CodeComplete.cpp
  clangd/CodeComplete.h
  unittests/clangd/ClangdTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52419.166667.patch
Type: text/x-patch
Size: 17383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180924/8fd9180f/attachment-0001.bin>


More information about the cfe-commits mailing list