[PATCH] D52334: [clang-tidy] Build it even without static analyzer

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In https://reviews.llvm.org/D52334#1242881, @steveire wrote:

> Thanks, that at least makes it more obvious where you are getting confused.
>
> See `tools/clang/lib/CMakeLists.txt`. It contains:
>
>   add_subdirectory(Analysis)
>   # ...
>   if(CLANG_ENABLE_STATIC_ANALYZER)
>     add_subdirectory(StaticAnalyzer)
>   endif()
>
>
>
>
> 1. That is: Analysis and StaticAnalyzer are different.
>
>   CLANG_ENABLE_STATIC_ANALYZER refers to the latter.
> 2. Also, something that may not have occurred to you: This patch does build. Obviously, if there were a problem with CFG after this patch, then it would not build.
>
>   Please keep both of those points in mind as you read the patch.


I expected, that you tested a build and running the unit tests as well ;)
What i suspected, that there are other parts directly in C++ source code that do an `if CLANG_ENABLE_STATIC_ANALYZER` to switch something on/off. I checked that now and it does not seem to be the case.

@alexfh should make the decision as the code-owner, but to me it makes sense to have clang-tidy without CSA.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52334