[PATCH] D45179: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre-C++2a [[nodiscard]]
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Sep 22 09:56:40 PDT 2018
EricWF added a comment.
In https://reviews.llvm.org/D45179#1241721, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45179#1225911, @EricWF wrote:
>
> > I don't think it ever landed. I'll try to get it in this week.
>
>
> What does this need?
> Is there some changes missing still?
> Or this simply needs to be committed (and bots watched?)
I think this was good to go. I was just waiting to give time for comments. Obviously I've waited long enough.
I'll work on this today.
https://reviews.llvm.org/D45179
More information about the cfe-commits
mailing list