[PATCH] D52390: [analyzer] StackSizeChecker

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 22 09:27:32 PDT 2018


Szelethus added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/StackSizeChecker.cpp:19
+#include "clang/AST/StmtCXX.h"
+#include "clang/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.h"
+#include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
----------------
Szelethus wrote:
> I bet you can't just `#include` this without getting some nasty buildbut errors down the line, just `#include "StackUsageMeasuringVisitor.h"`.
Oh never mind, you had it in `include/clang/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.h`. I bet it is for the clang-tidy check. Never mind.


================
Comment at: lib/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.cpp:17
+
+#include <clang/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.h>
+
----------------
Szelethus wrote:
> #include "StackUsageMeasuringVisitor.h"
Never mind, but should use `""` instead of `<>`.


Repository:
  rC Clang

https://reviews.llvm.org/D52390





More information about the cfe-commits mailing list