[PATCH] D52323: Add necessary support for storing code-model to module IR.

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

Note that if you add a line like:

"Depends on https://reviews.llvm.org/D52322" in the summary that Phabricator will automatically link the two in the right way.



================
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+                  .Default(~0u);
+    if ((CM != ~0u) && (CM != ~1u)) {
+      llvm::CodeModel::Model codeModel = static_cast<llvm::CodeModel::Model>(CM);
----------------
Can you simplify by using a single constant for both of these (since handling the same)?


================
Comment at: lib/CodeGen/CodeGenModule.h:38
 #include "llvm/IR/ValueHandle.h"
+#include "llvm/Support/CodeGen.h"
 #include "llvm/Transforms/Utils/SanitizerStats.h"
----------------
Since nothing changed in this header, should this new include be moved to CodeGenModule.cpp?


================
Comment at: test/CodeGen/codemodels.c:2
+// RUN: %clang_cc1 -emit-llvm  %s -o - | FileCheck %s -check-prefix=CHECK-NOMODEL
+// RUN: %clang_cc1 -emit-llvm -mcode-model small %s -o - | FileCheck %s -check-prefix=CHECK-SMALL
+// RUN: %clang_cc1 -emit-llvm -mcode-model kernel %s -o - | FileCheck %s -check-prefix=CHECK-KERNEL
----------------
Might as well check "tiny" and "default" as well for completeness.


Repository:
  rC Clang

https://reviews.llvm.org/D52323